Skip to content

Allow the dev server to watch for changes in src/node_modules #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2017
Merged

Allow the dev server to watch for changes in src/node_modules #3230

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80de217
Allow the dev server to watch for changes in src/node_modules
xjlim Oct 2, 2017
b0ef885
fix eslint error
xjlim Oct 2, 2017
eca7cf0
fix broken regex
xjlim Oct 3, 2017
2d6875f
handle trailing slash edge case for file paths
xjlim Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix broken regex
  • Loading branch information
@xjlim
xjlim committed Oct 3, 2017
commit eca7cf08f891c42e01d3bbab212de24a8051f162
2 changes: 1 addition & 1 deletion packages/react-scripts/config/webpackDevServer.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ module.exports = function(proxy, allowedHost) {
// src/node_modules is not ignored to support absolute imports
// https://github.com/facebookincubator/create-react-app/issues/1065
watchOptions: {
ignored: new RegExp(`^(?!${paths.appSrc})*[\\/]node_modules[\\/]`, 'g'),
ignored: new RegExp(`^(?!${paths.appSrc}).+[\\/]node_modules[\\/]`, 'g'),
},
// Enable HTTPS if the HTTPS environment variable is set to 'true'
https: protocol === 'https',
Expand Down