Skip to content

Stop using npm link in tests #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Oct 30, 2017
Merged

Stop using npm link in tests #3345

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
594b02a
Try a custom function
Timer Oct 28, 2017
85a1992
fix path
Timer Oct 28, 2017
0c62386
install rsync
Timer Oct 28, 2017
e6a696d
Test with node 8
Timer Oct 28, 2017
05d060f
Ensure package is removed from the tree
Timer Oct 28, 2017
b6e6f1c
Remove ours
Timer Oct 28, 2017
c567509
matching functions
Timer Oct 28, 2017
a736e39
try cygwin
Timer Oct 28, 2017
d9e2b34
try c:/
Timer Oct 28, 2017
2fe0106
sigh
Timer Oct 28, 2017
4a19ea9
Try /cygdrive/
gaearon Oct 29, 2017
2f5ffaf
Try /cygdrive/
gaearon Oct 29, 2017
e5df78b
Revert "Try /cygdrive/"
Timer Oct 29, 2017
7f6a4e0
Use sub-optimal copy
Timer Oct 29, 2017
4f1f598
Remove rsync install
Timer Oct 29, 2017
b926eba
Fix variable
Timer Oct 29, 2017
6e3c2a7
Continue on err
Timer Oct 29, 2017
810c806
Don't link react-scripts, lol
Timer Oct 29, 2017
c2c9db0
run yarn after eject
Timer Oct 29, 2017
3a2130e
re-enable cleanup
Timer Oct 29, 2017
e14903e
uninstall yarn
Timer Oct 29, 2017
47c056a
try with force
Timer Oct 29, 2017
2758cab
appveyor ... seriously?
Timer Oct 29, 2017
ce0c223
swallow bad eject
Timer Oct 29, 2017
6c7cdeb
remove eject error swallow
Timer Oct 29, 2017
2ca4c84
Revert "run yarn after eject"
Timer Oct 29, 2017
dea7cd7
Run yarn after eject
Timer Oct 29, 2017
e05bbbe
add a comment
Timer Oct 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run yarn after eject
  • Loading branch information
@Timer
Timer committed Oct 29, 2017
commit c2c9db0673605a9902360e5258c9c075ff870b96
17 changes: 2 additions & 15 deletions packages/react-scripts/scripts/eject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,21 +230,8 @@ inquirer
}

if (fs.existsSync(paths.yarnLockFile)) {
// TODO: this is disabled for three reasons.
//
// 1. It produces garbage warnings on Windows on some systems:
// https://github.com/facebookincubator/create-react-app/issues/2030
//
// 2. For the above reason, it breaks Windows CI:
// https://github.com/facebookincubator/create-react-app/issues/2624
//
// 3. It is wrong anyway: re-running yarn will respect the lockfile
// rather than package.json we just updated. Instead we should have
// updated the lockfile. So we might as well not do it while it's broken.
// https://github.com/facebookincubator/create-react-app/issues/2627
//
// console.log(cyan('Running yarn...'));
// spawnSync('yarnpkg', [], { stdio: 'inherit' });
console.log(cyan('Running yarn...'));
spawnSync('yarnpkg', [], { stdio: 'inherit' });
} else {
console.log(cyan('Running npm install...'));
spawnSync('npm', ['install', '--loglevel', 'error'], {
Expand Down