Skip to content

Re-enable yarn install on eject for non-windows machines #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Re-enable yarn install on eject for non-windows machines #3347

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
57df9e8
re-enable yarn on non-windows machines
Timer Oct 29, 2017
849a35c
Adjust packages using package managers
Timer Nov 5, 2017
f5d28e0
oops
Timer Nov 5, 2017
c2eb722
Specific versions
Timer Nov 5, 2017
9c57ba7
Avoid magic values
Timer Nov 5, 2017
b52f311
Check status of process
Timer Nov 5, 2017
48c343b
Output error when command fails
Timer Nov 5, 2017
51dc554
Rename vars
Timer Nov 5, 2017
1332a19
try yarn.cmd explicitly
Timer Nov 5, 2017
9e7833c
Use Node's spawn behavior except default to a shell on Windows
Timer Nov 19, 2017
f702acc
Support sync spawn, too
Timer Nov 19, 2017
90045fb
Don't clobber user's options object
Timer Nov 19, 2017
65d335e
Revert "Use Node's spawn behavior except default to a shell on Windows"
Timer Nov 19, 2017
814da9e
Skip cross spawn
Timer Nov 19, 2017
012d821
whoops
Timer Nov 19, 2017
6a26e57
No append cmd
Timer Nov 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support sync spawn, too
  • Loading branch information
@Timer
Timer committed Nov 19, 2017
commit f702accaf6d0e86547a8f422a788b64a5ec9b0d4
15 changes: 13 additions & 2 deletions packages/react-dev-utils/crossSpawn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

'use strict';

const { spawn } = require('child_process');
const { spawn, spawnSync } = require('child_process');

function crossSpawn(file, args, options) {
function normalizeSpawnArguments(file, args, options) {
if (typeof file !== 'string' || file.length === 0) {
throw new TypeError('"file" argument must be a non-empty string');
}
Expand All @@ -36,7 +36,18 @@ function crossSpawn(file, args, options) {
if (options.shell === undefined && process.platform === 'win32') {
options.shell = true;
}

return { file, args, options };
}

function crossSpawn(file, args, options) {
({ file, args, options } = normalizeSpawnArguments(file, args, options));
return spawn(file, args, options);
}

crossSpawn.sync = function crossSpawnSync(file, args, options) {
({ file, args, options } = normalizeSpawnArguments(file, args, options));
return spawnSync(file, args, options);
};

module.exports = crossSpawn;
2 changes: 1 addition & 1 deletion packages/react-scripts/scripts/eject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function adjustPackages(cwd, packages, append, dev) {
let status, output;
if (fs.existsSync(paths.yarnLockFile)) {
({ status, output } = spawnSync(
process.platform === 'win32' ? 'yarn.cmd' : 'yarnpkg',
'yarnpkg',
[append ? 'add' : 'remove', ...packages],
{
stdio: 'pipe',
Expand Down