Skip to content

Load favicon through html-loader. #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 12, 2016
Merged

Load favicon through html-loader. #428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c21c40
Load favicon through html-loader.
andreypopp Aug 12, 2016
50fce72
Add test for *.ico in e2e test suite
andreypopp Aug 12, 2016
edef7d3
Configure html-loader to process <link href="...">
andreypopp Aug 12, 2016
22b175d
Address feedback on html-loader inclusion.
andreypopp Aug 12, 2016
f35f725
Place favicon.ico at the root of the build dir
andreypopp Aug 12, 2016
58232c5
Make comment style consistent between prod and dev webpack configs
andreypopp Aug 12, 2016
38f668b
Fix html-loader config in dev mode
andreypopp Aug 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Configure html-loader to process <link href="...">
  • Loading branch information
@andreypopp
andreypopp committed Aug 12, 2016
commit edef7d39cb237b73589c3e8d630cf0a7124d5313
9 changes: 9 additions & 0 deletions config/webpack.config.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,15 @@ module.exports = {
limit: 10000,
name: 'static/media/[name].[ext]'
}
},
// "html" loader is used to process template page (index.html) to resolve
// resources linked with <link href="./relative/path"> HTML tags.
{
test: /\.html/,
Copy link
Contributor

@gaearon gaearon Aug 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should end with $?

loader: 'html',
query: {
attrs: ['link:href'],
Copy link
Contributor Author

@andreypopp andreypopp Aug 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be extended with other tag:attribute combinations.

Copy link
Contributor

@gaearon gaearon Aug 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh nice. Can you think up any other common combinations?

Copy link
Contributor Author

@andreypopp andreypopp Aug 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't bother adding more at the moment but rather serve on per-request basis.

Copy link
Contributor Author

@andreypopp andreypopp Aug 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think img:src is out of scope.

}
}
]
},
Expand Down
9 changes: 9 additions & 0 deletions config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,15 @@ module.exports = {
limit: 10000,
name: 'static/media/[name].[hash:8].[ext]'
}
},
// "html" loader is used to process template page (index.html) to resolve
// resources linked with <link href="./relative/path"> HTML tags.
{
test: /\.html/,
loader: 'html',
query: {
attrs: ['link:href'],
}
}
]
},
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
"filesize": "3.3.0",
"fs-extra": "0.30.0",
"gzip-size": "3.0.0",
"html-loader": "^0.4.3",
Copy link
Contributor

@gaearon gaearon Aug 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s drop caret here

"html-webpack-plugin": "2.22.0",
"http-proxy-middleware": "0.17.0",
"jest": "14.1.0",
Expand Down
2 changes: 1 addition & 1 deletion template/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="shortcut icon" href="${require('./src/favicon.ico')}">
<link rel="shortcut icon" href="./src/favicon.ico">
<title>React App</title>
</head>
<body>
Expand Down