-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
Suggest reactstrap instead of react-bootstrap
#4700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ```sh | ||
| npm install --save react-bootstrap bootstrap@3 | ||
| npm install bootstrap --save | ||
| npm install --save reactstrap react react-dom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be one line and read:
npm install --save reactstrap bootstrap@4|
|
||
| ```sh | ||
| yarn add react-bootstrap bootstrap@3 | ||
| yarn add bootstrap reactstrap react react-dom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove react and react-dom, then make bootstrap -> bootstrap@4.
| ```js | ||
| import 'bootstrap/dist/css/bootstrap.css'; | ||
| import 'bootstrap/dist/css/bootstrap-theme.css'; | ||
| import 'bootstrap/dist/css/bootstrap.min.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import 'bootstrap/dist/css/bootstrap.css';we minify css ourselves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot create-react-app minify css :). I fixed readme as you reviewed, Thanks!
| ``` | ||
|
|
||
| Import required React Bootstrap components within ```src/App.js``` file or your custom component files: | ||
| Import required Reactstrap components within ```src/App.js``` file or your custom component files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reactstrap
(lowercase please)
| ``` | ||
|
|
||
| Now you are ready to use the imported React Bootstrap components within your component hierarchy defined in the render method. Here is an example [`App.js`](https://gist.githubusercontent.com/gaearon/85d8c067f6af1e56277c82d19fd4da7b/raw/6158dd991b67284e9fc8d70b9d973efe87659d72/App.js) redone using React Bootstrap. | ||
| Now you are ready to use the imported Reactstrap components within your component hierarchy defined in the render method. Here is an example [`App.js`](https://gist.githubusercontent.com/zx6658/d9f128cd57ca69e583ea2b5fea074238/raw/a56701c142d0c622eb6c20a457fbc01d708cb485/App.js) redone using Reactstrap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reactstrap
(lowercase please)
|
@Timer i fixed it! i'm honor to get your review :) Thanks! |
|
It looks like you accidentally removed some sections. We still need that CSS import! |
|
@Timer i did it ! Thanks :) |
|
Perfect!! |
reactstrap instead of react-bootstrap
|
Oo crap, one last thing. You seemed to do this on |
|
@Timer Sure! |
I thought it would be great to recommend Reactstrap for now, instead of react-bootstrap. :)