Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add ref to jest svg transform and fix tests
  • Loading branch information
Gasim Gasimzada committed Oct 17, 2018
commit 2d28d2e0349f25e3c4b2f02ee68c0dd5a3c0b67d
4 changes: 2 additions & 2 deletions packages/react-scripts/config/jest/fileTransform.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ module.exports = {
return `module.exports = {
__esModule: true,
default: ${assetFilename},
ReactComponent: (props) => ({
ReactComponent: ({ svgRef, ...props }) => ({
$$typeof: Symbol.for('react.element'),
type: 'svg',
ref: null,
ref: svgRef || null,
key: null,
props: Object.assign({}, props, {
children: ${assetFilename}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
*/

import React from 'react';
import { ReactComponent as Logo } from './assets/logo.svg';
import { ReactComponent as Logo } from './logo.svg';

export default () => <Logo id="feature-svg-component" />;
export default () => {
return <Logo id="feature-svg-component" />;
};

export const SvgComponentWithRef = ({ ref }) => (
<Logo id="feature-svg-component-with-ref" svgRef={ref} />
export const SvgComponentWithRef = ({ svgRef }) => (
<Logo id="feature-svg-component-with-ref" svgRef={svgRef} />
);
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ describe('svg component', () => {
ReactDOM.render(<SvgComponentWithRef svgRef={someRef} />, div);
const svgElement = div.getElementsByTagName('svg');
expect(svgElement).toHaveLength(1);
expect(svgElement[0]).toBe(someRef);
expect(svgElement[0]).toBe(someRef.current);
});
});