Skip to content

Adding an exception for manifest.json when loading as json, fixes #558 #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jvorcak wants to merge 3 commits into from
Closed

Adding an exception for manifest.json when loading as json, fixes #558 #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0cd538
Adding an exception for manifest.json when loading as json, fixes #558
jvorcak Sep 3, 2016
5e161d0
Removed appSrc from include confition
jvorcak Sep 4, 2016
61b2a1f
Fix favicon.ico regexp
jvorcak Sep 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions config/webpack.config.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,22 +119,31 @@ module.exports = {
// allow it implicitly so we also enable it.
{
test: /\.json$/,
exclude: /\/manifest\.json$/,
loader: 'json'
},
// A special case for manifest.json to place it into build root directory.
{
test: /\/manifest\.json$/,
loader: 'file',
query: {
name: 'manifest.json?[hash:8]'
}
},
// "file" loader makes sure those assets get served by WebpackDevServer.
// When you `import` an asset, you get its (virtual) filename.
// In production, they would get copied to the `build` folder.
{
test: /\.(ico|jpg|png|gif|eot|otf|webp|svg|ttf|woff|woff2)(\?.*)?$/,
exclude: /\/favicon.ico$/,
exclude: /\/favicon\.ico$/,
loader: 'file',
query: {
name: 'static/media/[name].[hash:8].[ext]'
}
},
// A special case for favicon.ico to place it into build root directory.
{
test: /\/favicon.ico$/,
test: /\/favicon\.ico$/,
include: [paths.appSrc],
loader: 'file',
query: {
Expand Down
13 changes: 11 additions & 2 deletions config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,21 +130,30 @@ module.exports = {
// allow it implicitly so we also enable it.
{
test: /\.json$/,
exclude: /\/manifest\.json$/,
loader: 'json'
},
// A special case for manifest.json to place it into build root directory.
{
test: /\/manifest\.json$/,
loader: 'file',
query: {
name: 'manifest.json?[hash:8]'
}
},
// "file" loader makes sure those assets end up in the `build` folder.
// When you `import` an asset, you get its filename.
{
test: /\.(ico|jpg|png|gif|eot|otf|webp|svg|ttf|woff|woff2)(\?.*)?$/,
exclude: /\/favicon.ico$/,
exclude: /\/favicon\.ico$/,
loader: 'file',
query: {
name: 'static/media/[name].[hash:8].[ext]'
}
},
// A special case for favicon.ico to place it into build root directory.
{
test: /\/favicon.ico$/,
test: /\/favicon\.ico$/,
include: [paths.appSrc],
loader: 'file',
query: {
Expand Down