Skip to content

Support React Hooks (#5602) #5997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iansu merged 15 commits into from
Mar 15, 2019
Merged

Support React Hooks (#5602) #5997

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
24b9ce4
Add Babel plug-in for Hooks; Add ESLint plug-in for Hooks (WIP)
EivindArvesen Dec 9, 2018
d618e2c
Fix transform destructuring loose config
EivindArvesen Dec 9, 2018
a4f7584
Add eslint-plugin-react-hooks to package.json
EivindArvesen Dec 9, 2018
5028d85
Fix package.json's
EivindArvesen Dec 9, 2018
bd1dca0
Fix eslint-plugin-react-hooks version
EivindArvesen Dec 9, 2018
02aef13
Fix package.json
EivindArvesen Dec 9, 2018
093ed5b
Fix package.json
EivindArvesen Dec 9, 2018
b13b406
Add eslint-plugin-react-hooks to script package.json
EivindArvesen Dec 9, 2018
8dc1de4
Force array destructuring to work in loose mode only for known Hooks
EivindArvesen Feb 17, 2019
4feceaa
Merge branch 'master' into support-react-hooks
EivindArvesen Feb 17, 2019
36e33e5
Update based on feedback from PR
EivindArvesen Feb 19, 2019
32656d6
Add 'exhaustive-deps' lint rule
EivindArvesen Feb 28, 2019
aacc07f
Bump eslint-plugin-react-hooks to stable version
EivindArvesen Mar 7, 2019
cdbdacc
Merge branch 'master' into support-react-hooks
EivindArvesen Mar 13, 2019
0b13ab0
Remove extraneous dependency from react-scripts
iansu Mar 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix transform destructuring loose config
  • Loading branch information
@EivindArvesen
EivindArvesen committed Dec 9, 2018
commit d618e2c45b07c9de6dde1ba7e4bee38f03e2622a
14 changes: 8 additions & 6 deletions packages/babel-preset-react-app/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,14 @@ module.exports = function(api, opts, env) {
// Necessary to include regardless of the environment because
// in practice some other transforms (such as object-rest-spread)
// don't work without it: https://github.com/babel/babel/issues/7215
require('@babel/plugin-transform-destructuring').default,
{
// Use loose mode for performance:
// https://github.com/facebook/create-react-app/issues/5602
loose: true,
},
[
require('@babel/plugin-transform-destructuring').default,
{
// Use loose mode for performance:
// https://github.com/facebook/create-react-app/issues/5602
loose: true,
},
],
// Turn on legacy decorators for TypeScript files
isTypeScriptEnabled && [
require('@babel/plugin-proposal-decorators').default,
Expand Down