Skip to content

Bump eslint-plugin-react version and update webpack config #6132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2019
Merged

Bump eslint-plugin-react version and update webpack config #6132

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f0b53a
Bump eslint-plugin-react version and update webpack config
ianschmitz Jan 5, 2019
b57158a
Move eslint-plugin-react settings into eslint-config-react-app
ianschmitz Jan 6, 2019
71ea00f
Add react/no-typos rule
ianschmitz Jan 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move eslint-plugin-react settings into eslint-config-react-app
  • Loading branch information
@ianschmitz
ianschmitz committed Jan 6, 2019
commit b57158a605c4ef777f38183a85c875803dd3315c
6 changes: 6 additions & 0 deletions packages/eslint-config-react-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ module.exports = {
},
},

settings: {
react: {
version: 'detect',
},
},

rules: {
// http://eslint.org/docs/rules/
'array-callback-return': 'warn',
Expand Down
1 change: 0 additions & 1 deletion packages/react-scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,6 @@ module.exports = function(webpackEnv) {
// @remove-on-eject-begin
baseConfig: {
extends: [require.resolve('eslint-config-react-app')],
settings: { react: { version: 'detect' } },
},
ignore: false,
useEslintrc: false,
Expand Down