Skip to content

Avoid tons of *.json.gzip-files created in project root when running with docker node #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2016
Merged

Avoid tons of *.json.gzip-files created in project root when running with docker node #620

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a1070b
Specify cache directory for babel loader
thangngoc89 Sep 10, 2016
75965f1
Use `react-scripts` for folder name instead
thangngoc89 Sep 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions config/babel.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@
// @remove-on-eject-end

var path = require('path');
var findCacheDir = require('find-cache-dir');

module.exports = {
// Don't try to find .babelrc because we want to force this configuration.
babelrc: false,
// This is a feature of `babel-loader` for webpack (not Babel itself).
// It enables caching results in OS temporary directory for faster rebuilds.
cacheDirectory: true,
// It enables caching results in ./node_modules/.cache/create-react-app/
// directory for faster rebuilds.
cacheDirectory: findCacheDir({ name: 'create-react-app' }),
Copy link
Contributor

@fson fson Sep 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention seems to be that this should be the project name from package.json. Since this file is used by react-scripts, should we use react-scripts as the name here?

Copy link
Contributor

@gaearon gaearon Sep 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

presets: [
// Latest stable ECMAScript features
require.resolve('babel-preset-latest'),
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"extract-text-webpack-plugin": "1.0.1",
"file-loader": "0.9.0",
"filesize": "3.3.0",
"find-cache-dir": "^0.1.1",
"fs-extra": "0.30.0",
"gzip-size": "3.0.0",
"html-loader": "0.4.3",
Expand Down