Skip to content

refactor: remove double coerce #7882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2019
+3 −1
Merged

refactor: remove double coerce #7882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: remove double coerce
  • Loading branch information
@mrmckeb
mrmckeb committed Oct 25, 2019
commit 34fc3ff2276884ef728f32813fb0fd21ebe0d3b1
4 changes: 3 additions & 1 deletion packages/create-react-app/createReactApp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,8 @@ function run(
)
.then(({ isOnline, packageInfo, templateInfo }) => {
let packageVersion = semver.coerce(packageInfo.version);

// This environment variable can be removed post-release.
const templatesVersionMinimum = process.env.CRA_INTERNAL_TEST
? '3.2.0'
: '3.3.0';
Expand All @@ -454,7 +456,7 @@ function run(

// Only support templates when used alongside new react-scripts versions.
const supportsTemplates = semver.gte(
semver.coerce(packageVersion),
packageVersion,
templatesVersionMinimum
);
if (supportsTemplates) {
Expand Down