Skip to content

Add ESLint plugins for Jest, Jest DOM, and Testing Library #8155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Add ESLint plugins for Jest, Jest DOM, and Testing Library #8155

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ddb9007
Use Jest DOM and Testing Library ESLint plugins
nickserv Dec 9, 2019
7480e2d
Use Jest ESlint plugin
nickserv Dec 11, 2019
3679e2f
Fix linter errors in react-error-overlay tests
nickserv Dec 11, 2019
bef07e0
Only enable testing rules in test files
nickserv Dec 11, 2019
35664ef
Update new ESLint plugins
nickserv Feb 5, 2020
2645c54
Merge branch 'master' into testing-library-linting
nickserv Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only enable testing rules in test files
  • Loading branch information
@nickserv
nickserv committed Apr 23, 2020
commit bef07e09e8188e5782cd895aa3dc83f09ee1e2e4
17 changes: 11 additions & 6 deletions packages/eslint-config-react-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ module.exports = {

plugins: ['import', 'flowtype', 'jsx-a11y', 'react', 'react-hooks'],

extends: [
'plugin:jest/recommended',
'plugin:jest-dom/recommended',
'plugin:testing-library/react',
],

env: {
browser: true,
commonjs: true,
Expand Down Expand Up @@ -118,6 +112,17 @@ module.exports = {
'@typescript-eslint/no-useless-constructor': 'warn',
},
},
{
files: [
'**/__tests__/**/*.{js,jsx,ts,tsx}',
'**/*.{spec,test}.{js,jsx,ts,tsx}',
],
extends: [
'plugin:jest/recommended',
'plugin:jest-dom/recommended',
'plugin:testing-library/react',
],
},
],

// NOTE: When adding rules here, you need to make sure they are compatible with
Expand Down