Skip to content

Dispose error overlay when linting errors have been corrected #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2016
Merged

Dispose error overlay when linting errors have been corrected #856

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c18164
Dispose error overlay when linting errors have been corrected
jarlef Oct 5, 2016
15672ac
Fixed spelling error
jarlef Oct 10, 2016
34c739b
Minor style tweaks
gaearon Oct 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Minor style tweaks
  • Loading branch information
@gaearon
gaearon authored Oct 11, 2016
commit 34c739bdf7a17c599cbc4995ed5e659ee0de3e11
11 changes: 6 additions & 5 deletions packages/react-dev-utils/webpackHotDevClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,13 @@ function showErrorOverlay(message) {
});
}

function destroyOverlay() {
if(!overlayDiv) {
//linting from previous linting was successful
function destroyErrorOverlay() {
if (!overlayDiv) {
// It is not there in the first place.
return;
}

// Clean up and reset internal state.
document.body.removeChild(overlayIframe);
overlayDiv = null;
overlayIframe = null;
Expand Down Expand Up @@ -168,7 +169,7 @@ function clearOutdatedErrors() {
// Successful compilation.
function handleSuccess() {
clearOutdatedErrors();
destroyOverlay();
destroyErrorOverlay();

var isHotUpdate = !isFirstCompilation;
isFirstCompilation = false;
Expand All @@ -183,7 +184,7 @@ function handleSuccess() {
// Compilation with warnings (e.g. ESLint).
function handleWarnings(warnings) {
clearOutdatedErrors();
destroyOverlay();
destroyErrorOverlay();

var isHotUpdate = !isFirstCompilation;
isFirstCompilation = false;
Expand Down