Skip to content

Drop Node 8 support #8948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 4, 2020
Merged

Drop Node 8 support #8948

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dae7eb0
Drop Node 8 support
ianschmitz May 3, 2020
c89a789
Fix node version for old node test suite
ianschmitz May 3, 2020
a16cec8
Bump node-sass in test suite
ianschmitz May 3, 2020
856b775
Upgrade pupeteer
ianschmitz May 3, 2020
258f12e
Fix CLI min node check
ianschmitz May 3, 2020
d5c6c47
Revert to ubuntu 16.04
ianschmitz May 4, 2020
1664c60
Merge remote-tracking branch 'upstream/master' into drop-node-8
ianschmitz May 4, 2020
dfa1f89
Fix sass test
ianschmitz May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix sass test
  • Loading branch information
@ianschmitz
ianschmitz committed May 4, 2020
commit dfa1f89dd5f059565234ac61c62855260e4a50bf
15 changes: 0 additions & 15 deletions test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,21 +156,6 @@ Failed to compile.
Attempted import error: 'bar' is not exported from './AppUnknownExport'.


",
"stdout": "",
}
`;

exports[`helps when users tries to use sass 1`] = `
Object {
"stderr": "Creating an optimized production build...
Failed to compile.

./src/AppSass.scss
To import Sass files, you first need to install node-sass.
Run \`npm install node-sass\` or \`yarn add node-sass\` inside your workspace.


",
"stdout": "",
}
Expand Down
6 changes: 5 additions & 1 deletion test/fixtures/webpack-message-formatting/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ test('helps when users tries to use sass', async () => {
);

const { stdout, stderr } = await testSetup.scripts.build();
expect({ stdout, stderr }).toMatchSnapshot();
expect(stdout).toBeFalsy();
// TODO: Snapshots differ between Node 10/12 as the call stack log output has changed.
expect(stderr).toContain(
'To import Sass files, you first need to install node-sass.'
);
});

test('formats file not found error', async () => {
Expand Down