Skip to content

Enable babel parameters/destructuring for all versions of Node #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2016
Merged

Enable babel parameters/destructuring for all versions of Node #927

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c3be49
Enable babel parameters/destructuring for all versions of Node
JeffreyATW Oct 18, 2016
29711b8
Add more descriptive comment explaining plugin use
JeffreyATW Oct 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add more descriptive comment explaining plugin use
  • Loading branch information
@JeffreyATW
JeffreyATW committed Oct 18, 2016
commit 29711b820f393aff0d8e536cb38c77d558b2249a
5 changes: 5 additions & 0 deletions packages/babel-preset-react-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,13 @@ const plugins = [
// Resolve the Babel runtime relative to the config.
moduleName: path.dirname(require.resolve('babel-runtime/package'))
}],
// The following two plugins are currently necessary to get
// babel-preset-env to work with rest/spread. More info here:
// https://github.com/babel/babel-preset-env#caveats
// https://github.com/babel/babel/issues/4074
// const { a, ...z } = obj;
Copy link
Contributor

@gaearon gaearon Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a note here specifically mentioning why we need them, and link to the issue.

Copy link
Contributor Author

@JeffreyATW JeffreyATW Oct 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

require.resolve('babel-plugin-transform-es2015-destructuring'),
// const fn = ({ a, ...otherProps }) => otherProps;
require.resolve('babel-plugin-transform-es2015-parameters')
];

Expand Down