Skip to content

Don't assume the project is hosted at the root #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2016
Merged

Don't assume the project is hosted at the root #94

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0081f76
Don't assume the project is hosted at the root
dhruska Jul 22, 2016
17ced6b
Fix package.json path and add sample package.json for tests
dhruska Jul 23, 2016
24c9c9b
Update publicPath to use relative path portion of URL defined in home…
dhruska Jul 24, 2016
e2dc775
Update successful bundle generation message
dhruska Jul 24, 2016
d16a092
Show bundle generation success message based on presence of homepage …
dhruska Jul 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update publicPath to use relative path portion of URL defined in home… 
…page
  • Loading branch information
@dhruska
dhruska committed Jul 24, 2016
commit 24c9c9b9d677733bedf1727cd8400fd626d6f3c9
4 changes: 3 additions & 1 deletion config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ var autoprefixer = require('autoprefixer');
var webpack = require('webpack');
var HtmlWebpackPlugin = require('html-webpack-plugin');
var ExtractTextPlugin = require('extract-text-webpack-plugin');
var url = require('url');

// TODO: hide this behind a flag and eliminate dead code on eject.
// This shouldn't be exposed to the user.
Expand All @@ -26,7 +27,8 @@ var nodeModulesPath = path.join(__dirname, '..', 'node_modules');
var indexHtmlPath = path.resolve(__dirname, relativePath, 'index.html');
var faviconPath = path.resolve(__dirname, relativePath, 'favicon.ico');
var buildPath = path.join(__dirname, isInNodeModules ? '../../..' : '..', 'build');
var publicPath = require(path.resolve(__dirname, relativePath, 'package.json')).homepage || '/';
var homepagePath = require(path.resolve(__dirname, relativePath, 'package.json')).homepage;
var publicPath = homepagePath ? url.parse(homepagePath).pathname : '/';

module.exports = {
bail: true,
Expand Down