Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
100e6f0
Add mvfst and usdt dependencies
mszabo-wikia Dec 28, 2024
bd28a6d
Fix thrift build
mszabo-wikia Dec 28, 2024
a89cab9
IWYU: add missing includes to hphp/util
mszabo-wikia Dec 28, 2024
e835042
Fix phph/hhbbc/index.cpp compilation
mszabo-wikia Dec 28, 2024
daf5e8f
IWYU: fix boost include in hphp/compiler/systemlib.cpp
mszabo-wikia Dec 28, 2024
b04b9de
Update OCaml stubs
mszabo-wikia Dec 28, 2024
37bedcf
Remove nonexistent actions runner label
mszabo-wikia Dec 28, 2024
b6c729c
Require the ldap package
mszabo-wikia Dec 28, 2024
d8e4227
Provide OCaml env vars for ocamlrep crate
mszabo-wikia Dec 28, 2024
a242505
IWYU: Add missing cstdint include to hdf.h
mszabo-wikia Dec 28, 2024
cf1e500
Update folly patches
mszabo-wikia Dec 28, 2024
160bb31
IWYU: Add missing cstdint include to fcall-args-flags.h
mszabo-wikia Dec 28, 2024
e48eca6
Fix hhbc-unit.h generation
mszabo-wikia Apr 14, 2025
f628311
Use system libraries for xxhash, lz4 and double-conversion
mszabo-wikia Dec 28, 2024
0fc5180
Use vendored fast_float library for folly
mszabo-wikia Dec 28, 2024
3fff398
Don't build squangle and mcrouter for OSS for now
mszabo-wikia Dec 28, 2024
8e7978f
Add missing extension dependencies
mszabo-wikia Dec 28, 2024
c7ebb9c
hack: skip building blake3 hash for now
mszabo-wikia Dec 28, 2024
5d0b9cc
Fix HPHP::Facts::Clock formatter compat with newer libfmt
mszabo-wikia Dec 28, 2024
1944a3d
Disable more broken extensions
mszabo-wikia Dec 28, 2024
0fe5118
Allow building with system lz4
mszabo-wikia Dec 28, 2024
7fd1fae
Fix spammy -Winconsistent-override in transport.h
mszabo-wikia Dec 28, 2024
c5836c6
Fix TBB clang patch
mszabo-wikia Dec 28, 2024
fc008e4
Attempt to workaround build races
mszabo-wikia Dec 28, 2024
a5b799a
Install and force libc++ for the OSS build
mszabo-wikia Dec 29, 2024
447d474
Silence spammy 'non-local-definitions' rust lint
mszabo-wikia Dec 29, 2024
b19d4d7
Use LLVM 17 to satisfy C++20 requirements
mszabo-wikia Dec 29, 2024
5c2e46e
Build xed since it's now required
mszabo-wikia Dec 29, 2024
61ba31e
Parallelize the folly build
mszabo-wikia Dec 29, 2024
a95f96a
Update Fizz patches
mszabo-wikia Dec 29, 2024
2d3e1a4
Update third-party GitHub actions
mszabo-wikia Dec 30, 2024
61fbbb6
Switch CI from Focal to Jammy
mszabo-wikia Dec 31, 2024
9bde7ca
Use single Rust staticlib for FFI
mszabo-wikia Dec 31, 2024
1bf9336
Use underlying type for formatting HPHP::jit::Opcode to fix debug build
mszabo-wikia Jan 3, 2025
6c72d83
Ensure Rust commands execute after OPAM setup
mszabo-wikia Jan 3, 2025
d83bea7
Generate config headers from configs.specification
mszabo-wikia Dec 28, 2024
50fd553
Add missing dependencies for gd and lmdb extensions
mszabo-wikia Jan 3, 2025
05bce3c
Link fizz against liboqs transitively if it was found
mszabo-wikia Jan 3, 2025
2f0537b
Pass CMAKE_CXX_FLAGS to tbb
mszabo-wikia Jan 3, 2025
f4adc41
Add missing 'long long' rr::serialize() specialization
mszabo-wikia Jan 3, 2025
0d048aa
support new libdwarfp API
mszabo-wikia Jan 5, 2025
a191e1d
Fix tc-print link order
mszabo-wikia Jan 5, 2025
d78103d
Fix compilation error with OpenSSL 3
Atry Nov 2, 2022
2c852c6
Update systemlib generation to support precompiled systemlibs
mszabo-wikia Dec 28, 2024
8b7b7dc
Use an Ubuntu 24.04 CI
mszabo-wikia Jan 5, 2025
aa261e8
Fix ocamlrep_marshal dune lock
mszabo-wikia Jan 5, 2025
111aaea
Use Opensource Team-approved runner label
mszabo-wikia Jan 6, 2025
f69bcc8
Fix tc-print subdirectory load order
mszabo-wikia Jan 6, 2025
d961623
Switch back to RelWithDebInfo builds after stabilizing CI
mszabo-wikia Jan 7, 2025
eb738bd
Stabilize ocaml build
mszabo-wikia Feb 1, 2025
6d6bc93
Update mvfst submodule ref
mszabo-wikia Feb 1, 2025
c5eb5ae
Lowercase fizz reference
mszabo-wikia Feb 2, 2025
28a73ad
Undefine a MySQL constant until the client is updated
mszabo-wikia Feb 10, 2025
bbc894d
Remove outdated Squangle patches
mszabo-wikia Feb 10, 2025
3ed54e1
Use C++20 for building Squangle
mszabo-wikia Feb 12, 2025
1fcf206
Forward CMAKE_CXX_STANDARD to fizz, mvfst and wangle
mszabo-wikia Feb 13, 2025
ac9c2e3
Remove SSE4.2 and AVX2 toggles in favor of march=x86-64-v3
mszabo-wikia Feb 14, 2025
3983f8a
Add sandcastle module dependency
mszabo-wikia Mar 13, 2025
89cf837
Add diagnostics stub
mszabo-wikia Mar 18, 2025
fad39e0
Update mvfst submodule
mszabo-wikia Mar 18, 2025
ff447bf
Update to Rust 1.87
mszabo-wikia Apr 14, 2025
8c55b2d
Stub DeclarationsRewriter.rename_decls
mszabo-wikia Apr 14, 2025
a9622e4
Update cargo lockfile
mszabo-wikia Mar 18, 2025
0b1d1a3
Include cxxabi and libunwind headers in unique-stubs.cpp
mszabo-wikia Apr 15, 2025
97cd6cb
Drop unused headers
mszabo-wikia May 13, 2025
bb5397d
Fix OCaml stubs
mszabo-wikia May 15, 2025
ebbeaab
Add libbpf dependency
mszabo-wikia May 16, 2025
5a8b8f9
Silence noisy nontrivial-memcall diagnostic on clang 20
mszabo-wikia May 16, 2025
d1d7c5f
Try to use a new runner label
mszabo-wikia May 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix spammy -Winconsistent-override in transport.h
  • Loading branch information
mszabo-wikia committed May 29, 2025
commit 7fd1faeb9d1c49ef58aa762d0bb291adf598112c
8 changes: 4 additions & 4 deletions hphp/runtime/server/transport.h
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ struct Transport : IDebuggable, ITransportHeaders {
/**
* Request URI.
*/
virtual const char *getUrl() = 0;
virtual const char *getUrl() override = 0;
virtual const char *getRemoteHost() = 0;
virtual uint16_t getRemotePort() = 0;
// The transport can override REMOTE_ADDR if it has one
Expand Down Expand Up @@ -213,7 +213,7 @@ struct Transport : IDebuggable, ITransportHeaders {
/**
* POST request's data.
*/
virtual const void *getPostData(size_t &size) = 0;
virtual const void *getPostData(size_t &size) override = 0;
virtual bool hasMorePostData() { return false; }
virtual const void *getMorePostData(size_t &size) { size = 0;return nullptr; }
virtual bool getFiles(std::string& /*files*/) { return false; }
Expand All @@ -228,7 +228,7 @@ struct Transport : IDebuggable, ITransportHeaders {
/**
* Is this a GET, POST or anything?
*/
virtual Method getMethod() = 0;
virtual Method getMethod() override = 0;
virtual const char *getExtendedMethod() { return nullptr;}
const char *getMethodName() override;

Expand Down Expand Up @@ -387,7 +387,7 @@ struct Transport : IDebuggable, ITransportHeaders {
* foo/bar?x=1 command is "foo/bar"
* /foo/bar?x=1 command is "foo/bar"
*/
std::string getCommand();
std::string getCommand() override;

/**
* Get value of a parameter. Returns empty string is not present.
Expand Down