Fix Windows vs posix build inconsistency in module path hints on dev#1568
Closed
Fix Windows vs posix build inconsistency in module path hints on dev#1568
Conversation
Summary: When building bundles with `dev=true`, Metro adds project-relative module paths to module define call params, which populate `module.verboseName`. Currently, this wrongly varies if the bundle happens to have been built on a Windows machine, due to using system path separators. Metro's output should not depend on where Metro is running. This normalises to posix separators, adding a utility function we also make use of elsewhere. ``` - **[Fix]** `module.verboseName` (dev builds only) now uses posix separators regardless of the OS the bundle is built on ``` Differential Revision: D81675832
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81675832 |
Contributor
|
This pull request has been merged in bd80558. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When building bundles with
dev=true, Metro adds project-relative module paths to module define call params, which populatemodule.verboseName.Currently, this wrongly varies if the bundle happens to have been built on a Windows machine, due to using system path separators. Metro's output should not depend on where Metro is running.
This normalises to posix separators, adding a utility function we also make use of elsewhere.
Differential Revision: D81675832