Add missing types to RunBuildOptions and export RunBuildResult#1621
Closed
pafry7 wants to merge 2 commits intofacebook:mainfrom
Closed
Add missing types to RunBuildOptions and export RunBuildResult#1621pafry7 wants to merge 2 commits intofacebook:mainfrom
pafry7 wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
pafry7
force-pushed
the
fix/runbuildoptions-assets-type
branch
from
fe0f613 to
144f4a5
Compare
pafry7
changed the title
pafry7
changed the title
pafry7
force-pushed
the
fix/runbuildoptions-assets-type
branch
from
144f4a5 to
1ac9718
Compare
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit added the
assetsboolean toRunBuildOptionsas well asRunBuildResulttype, butindex.d.tswas not changed, which causes missing type errors.Changelog: [Fix] missing types for
runBuildcommandTest plan