Fix entryFile always is assumed to end with .js extension
#310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it assumed entryFile will end with `*.js`, which is not always true. Instead, we pass it into the resolution logic to correctly determine the actual path to the entryFile.
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 86.31% 86.32% +0.01%
==========================================
Files 163 163
Lines 4916 4913 -3
Branches 753 751 -2
==========================================
- Hits 4243 4241 -2
+ Misses 600 599 -1
Partials 73 73
Continue to review full report at Codecov.
|
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mjesun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
thymikee
added a commit
to thymikee/metro
that referenced
this pull request
Mar 3, 2019
…ation * upstream/master: (42 commits) Bump [email protected] Fix entryFile always is assumed to end with `.js` extension (facebook#310) Adds support for `publicPath` to enable serving assets from different locations. (facebook#299) Make dynamic import interoperable for CJS and ESM Add custom serializer (facebook#309) React sync for revisions 4773fdf...3ff2c7c metro-buck: disable inline IDs in dev mode Simplify helper function Rewrite traverseDependency-integration-tests to make them module resolution unit tests RN: Revert React 16.6 Sync React sync for revisions 4773fdf...bf9fadf Bump react-deep-force-update Use getFileIterator() from jest-haste-map Deploy Flow v0.85 to xplat/js metro-buck: add explicit import() prefetch feature jest: remove jasmine usages jest: upgrade to 24.0.0-alpha.4 Fix source map loading in the remote debugger Fix metro visualizer transformation Update babel to version 7 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When making a request to metro server with
.bundlesuffix, if this source file was named with.jsxor.ts, metro isn't able to find the resource. Instead, an error message is shown indicating there isn't such file associated with.jsextension.This PR addresses this issue by passing the entryFile name in the URL into the module resolution system, which will handle various extensions gracefully.
Test plan
.jsxextension.