-
Notifications
You must be signed in to change notification settings - Fork 674
Update siteConfig.js #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update siteConfig.js #327
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=======================================
Coverage 85.18% 85.18%
=======================================
Files 169 169
Lines 5082 5082
Branches 777 777
=======================================
Hits 4329 4329
Misses 671 671
Partials 82 82Continue to review full report at Codecov.
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
cpojer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…ation * upstream/master: (122 commits) Bump Metro to v0.53.0 Improve flow coverage in Metro Enable platform transforms for dev too, but keep it safe for MetroResolver Use function maps to symbolicate traces Move react-native-symbolicate to metro repo Migrated Metro from babel-jest to a custom transformer React sync for revisions f24a0da...8e25ed2 Revert D14168466: Perform security fixes Adds a missing dependency to metro Bumps antd to fix missing peerdeps Updates the package.json to match the Yarn output Improve prelude code Perform security fixes metro-buck: setup __DEV__ and other variables on the global object Add README and development script (facebook#292) Allow custom BABEL_ENV (facebook#364) Update siteConfig.js (facebook#327) docs: mention lerna in CONTRIBUTING.md (facebook#338) Revert D14024934: metro: keep track of significant dependencies ordering metro-buck: Hermes: no args to async wrapper if no prefetch ...
Summary
Favicon Link not working currently because of invalid href link in index.html also the img extension was written as ico instead of png, however its fixed now and is working fine! was updated under siteConfig.js.
Test plan
you can view a preview here hosted on gh-pages "https://developerayo.github.io/metro/"
@mjesun