replace "required" column in code reference with special label #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-native ready! Built with commit 9af918e https://deploy-preview-1959--react-native.netlify.app Changes to Thank you for your contributions. |
nearestnabors
approved these changes
May 29, 2020
Contributor
nearestnabors
left a comment
nearestnabors
left a comment
There was a problem hiding this comment.
These new required labels are tops! Thanks so much for iterating over these in earnest and getting them just right for our readers :)
Simek
added
the
Design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new "Required" label for the Code Reference properties which also replaces the "Required" column in the descriptions making more space for the default value and other columns.
I have updated the two modified earlier pages (
ActivityIndicator&Button) and thePressablepage which already follows most of new guidelines.I have also adjusted the type of callbacks here which involves
PressEventto be more accurate and consistent with the actual representation.Preview