Small tweak in 'Integration with existing apps' #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a small followup to my PR facebook#166. This makes it more likely people will install the correct version of React. I was just reading the guide again now and realized it's easy copy&paste commands without reading the text around them, and install a wrong version of React.
|
Deploy preview for react-native ready! Built with commit 7c23438 |
charpeni
approved these changes
Feb 20, 2018
Contributor
charpeni
left a comment
charpeni
left a comment
There was a problem hiding this comment.
Thank you Martin!
Hopefully they won't try to install react@version_printed_above, but a least the warning message will be clear enough.
No matching version found for react@version_printed_above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small followup to my PR #166.
This makes it more likely people will install the correct version of React.
I was just reading the guide again now and realized it's easy copy&paste commands without reading the text around them, and install a wrong version of React.