Cast name to String to ensure .match is available #12447
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
👍 @facebook-github-bot shipit |
Contributor
|
@janicduplessis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
GaborWnuk
pushed a commit
to GaborWnuk/react-native
that referenced
this pull request
Feb 28, 2017
Summary: PR for issue facebook#12444 In `validateProjectName` in `react-native-cli` `name.match` is called but it's not certain that `name`is a String. This casts `name`to a String before doing the match. I didn't find any tests for this file so I didn't add any. Reproduce: ``` cd react-native-cli npm install node index.js init 123 ``` Before this PR the code throws an exception, after this PR the intended `console.error` is printed. Closes facebook#12447 Differential Revision: D4584041 fbshipit-source-id: 117e76570aa9975ac851192b030c5a77daf19bcc
dudeinthemirror
pushed a commit
to dudeinthemirror/react-native
that referenced
this pull request
Mar 1, 2017
Summary: PR for issue facebook#12444 In `validateProjectName` in `react-native-cli` `name.match` is called but it's not certain that `name`is a String. This casts `name`to a String before doing the match. I didn't find any tests for this file so I didn't add any. Reproduce: ``` cd react-native-cli npm install node index.js init 123 ``` Before this PR the code throws an exception, after this PR the intended `console.error` is printed. Closes facebook#12447 Differential Revision: D4584041 fbshipit-source-id: 117e76570aa9975ac851192b030c5a77daf19bcc
dudeinthemirror
pushed a commit
to dudeinthemirror/react-native
that referenced
this pull request
Mar 1, 2017
Summary: PR for issue facebook#12444 In `validateProjectName` in `react-native-cli` `name.match` is called but it's not certain that `name`is a String. This casts `name`to a String before doing the match. I didn't find any tests for this file so I didn't add any. Reproduce: ``` cd react-native-cli npm install node index.js init 123 ``` Before this PR the code throws an exception, after this PR the intended `console.error` is printed. Closes facebook#12447 Differential Revision: D4584041 fbshipit-source-id: 117e76570aa9975ac851192b030c5a77daf19bcc
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 28, 2018
Summary: PR for issue #12444 In `validateProjectName` in `react-native-cli` `name.match` is called but it's not certain that `name`is a String. This casts `name`to a String before doing the match. I didn't find any tests for this file so I didn't add any. Reproduce: ``` cd react-native-cli npm install node index.js init 123 ``` Before this PR the code throws an exception, after this PR the intended `console.error` is printed. Closes facebook/react-native#12447 Differential Revision: D4584041 fbshipit-source-id: 117e76570aa9975ac851192b030c5a77daf19bcc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #12444
In
validateProjectNameinreact-native-cliname.matchis called but it's not certain thatnameis a String. This castsnameto a String before doing the match.I didn't find any tests for this file so I didn't add any.
Reproduce:
Before this PR the code throws an exception, after this PR the intended
console.erroris printed.