close <audio> tag. Some debugger (ex: remote-redux-devtools-on-debu…
#13798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gger) inject html code to debugger.html will be incidentily wrapped in the `<audio>` tag.
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
GH Review: accepted
Import Started
|
@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: [remote-redux-devtools-on-debugger](https://github.com/jhen0409/remote-redux-devtools-on-debugger) is a redux debugger UI for react-native. It inject code to debugger.html to communicate to the [Remote Redux DevTools](https://github.com/zalmoxisus/remote-redux-devtools). But the injecting failed for react-native 0.44 because the injected code will be wrapped in the audio tag. Here's the screenshot:  The pull request close the `<audio>` tag to make sure the injecting code not wrap inside `<audio>` tag  `$ npm install --save-dev remote-redux-devtools-on-debugger` `$ ./node_modules/.bin/remotedev-debugger --hostname localhost --port 5678 --injectserver` $ open debugger.html in the browser, open the chrome dev tool, make sure the injected code not wrapped in the audio tag. If you have added code that should be tested, add tests. Sign the [CLA][2], if you haven't already. Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged. For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines. [1]: https://medium.com/martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9 [2]: https://code.facebook.com/cla [3]: https://travis-ci.org/facebook/react-native [4]: http://circleci.com/gh/facebook/react-native [5]: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests Closes facebook/react-native#13798 Differential Revision: D5154006 Pulled By: shergin fbshipit-source-id: bd5f1774108649774b33ff2bf38d1aee3a5c50a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation (required)
remote-redux-devtools-on-debugger is a redux debugger UI for react-native. It inject code to debugger.html to communicate to the Remote Redux DevTools. But the injecting failed for react-native 0.44 because the injected code will be wrapped in the audio tag. Here's the screenshot:
The pull request close the
<audio>tag to make sure the injecting code not wrap inside<audio>tagTest Plan (required)
$ npm install --save-dev remote-redux-devtools-on-debugger$ ./node_modules/.bin/remotedev-debugger --hostname localhost --port 5678 --injectserver$ open debugger.html in the browser, open the chrome dev tool, make sure the injected code not wrapped in the audio tag.
If you have added code that should be tested, add tests.
Next Steps
Sign the CLA, if you haven't already.
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.