Updated the Android Setup with correct SDK package to install. #6185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of "Android Support Library" is now "Local Maven repository for Support Libraries". This also updates the screenshot.
|
By analyzing the blame information on this pull request, we identified @mkonicek, @BerndWessels and @sunnylqm to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Cool, thanks a lot! Will merge this. |
|
👍👍 I spend 1h struggling to setup Android build to finally understand that yeh you need "Local Maven repository for Support Libraries". Would be great to update docs. |
ghost
closed this
in
mkonicek
pushed a commit
that referenced
this pull request
Mar 7, 2016
Summary:The "Android Support Library" package is now named "Local Maven repository for Support Libraries", so this updates the docs and screenshot accordingly. Closes #6185 Reviewed By: mkonicek Differential Revision:D3017638 Ninja: oss only (rn website) Pulled By: mkonicek fb-gh-sync-id: 3559a9f09930e7606af7912e7aaee3c4215c1b03 shipit-source-id: 3559a9f09930e7606af7912e7aaee3c4215c1b03
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary:The "Android Support Library" package is now named "Local Maven repository for Support Libraries", so this updates the docs and screenshot accordingly. Closes facebook#6185 Reviewed By: mkonicek Differential Revision:D3017638 Ninja: oss only (rn website) Pulled By: mkonicek fb-gh-sync-id: 3559a9f09930e7606af7912e7aaee3c4215c1b03 shipit-source-id: 3559a9f09930e7606af7912e7aaee3c4215c1b03
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Android Support Library" package is now named "Local Maven repository for Support Libraries", so this updates the docs and screenshot accordingly.