Skip to content

Conversation

bestander
Copy link
Contributor

I suppose over time we should simplify the script.
But for now this will do.

Logic:

  1. don't copy "blog" folder to /releases/XX when doing a docs release
  2. don't copy "blog" folder to / when doing stable docs release
  3. copy "blog" folder to / only when doing building docs for master branch

CC @vjeux

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @bestander to be a potential reviewer.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 24, 2016
@vjeux
Copy link
Contributor

vjeux commented Mar 24, 2016

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 05b8944 Mar 24, 2016
@vjeux
Copy link
Contributor

vjeux commented Mar 25, 2016

Okay, just realized that we also need to copy the following files over: website/src/img/blog/*

@bestander
Copy link
Contributor Author

Damn, can't we have images with the blog?

On Friday, 25 March 2016, Christopher Chedeau [email protected]
wrote:

Okay, just realized that we also need to copy the following files over:
website/src/img/blog/*


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6634 (comment)

@vjeux
Copy link
Contributor

vjeux commented Mar 25, 2016

Yeah we can, let me do that

zebulgar pushed a commit to nightingale/react-native that referenced this pull request Jun 18, 2016
Summary:I suppose over time we should simplify the script.
But for now this will do.

Logic:
1. don't copy "blog" folder to /releases/XX when doing a docs release
2. don't copy "blog" folder to / when doing stable docs release
3. copy "blog" folder to / only when doing building docs for master branch

CC vjeux
Closes facebook#6634

Differential Revision: D3094267

Pulled By: vjeux

fb-gh-sync-id: 1f972703ed371c114e34d9f524092ea1d2fd985b
shipit-source-id: 1f972703ed371c114e34d9f524092ea1d2fd985b
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants