Add "Open file" button to elements inspector #7005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
So cool!!! I've got to get this into the react devtools too |
|
this is incredible!! |
|
@frantic updated the pull request. |
|
@sahrens would you mind taking a look at this pull request? It's been a while since the last commit was reviewed. |
Contributor
Author
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary: Depends on facebook#6351 Now you can open file directly from Elements Inspector! Credit for the original implementation goes to jaredly  **Test plan** Made sure it doesn't crash the app with or without facebook#6351 (i.e. can be merged safely before facebook#6351 gets in). Closes facebook#7005 Differential Revision: D3313714 Pulled By: frantic fbshipit-source-id: 3b80abd3e81a0db5ca5136e2d2c94c775fa04f3a
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: Depends on facebook#6351 Now you can open file directly from Elements Inspector! Credit for the original implementation goes to jaredly  **Test plan** Made sure it doesn't crash the app with or without facebook#6351 (i.e. can be merged safely before facebook#6351 gets in). Closes facebook#7005 Differential Revision: D3313714 Pulled By: frantic fbshipit-source-id: 3b80abd3e81a0db5ca5136e2d2c94c775fa04f3a
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Depends on facebook#6351 Now you can open file directly from Elements Inspector! Credit for the original implementation goes to jaredly  **Test plan** Made sure it doesn't crash the app with or without facebook#6351 (i.e. can be merged safely before facebook#6351 gets in). Closes facebook#7005 Differential Revision: D3313714 Pulled By: frantic fbshipit-source-id: 3b80abd3e81a0db5ca5136e2d2c94c775fa04f3a
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #6351
Now you can open file directly from Elements Inspector!
Credit for the original implementation goes to @jaredly
Test plan
Made sure it doesn't crash the app with or without #6351 (i.e. can be merged safely before #6351 gets in).