Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 14771a7
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: aa115f7
Choose a head ref
  • 5 commits
  • 20 files changed
  • 2 contributors

Commits on Feb 1, 2018

  1. Invoke both legacy and UNSAFE_ lifecycles when both are present (#12134)

    * Invoke both legacy and UNSAFE_ lifecycles when both are present
    
    This is to support edge cases with eg create-react-class where a mixin defines a legacy lifecycle but the component being created defines an UNSAFE one (or vice versa).
    
    I did not warn about this case because the warning would be a bit redundant with the deprecation warning which we will soon be enabling. I could be convinced to change my stance here though.
    
    * Added explicit function-type check to SS ReactPartialRenderer
    bvaughn authored Feb 1, 2018
    Configuration menu
    Copy the full SHA
    4eed18d View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2018

  1. Configuration menu
    Copy the full SHA
    8a995f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4da13ec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    885a291 View commit details
    Browse the repository at this point in the history
  4. Extend input type check in selection capabilities (#12062)

    When an email input was replaced by a disabled text input on the same
    DOM position, an error would occur when trying to `setSelection`. The
    reason was that in `getSelectionInformation` the `selectionRange` was
    set to `null` as `hasSelectionCapabilities` was returning `false` for
    an `email` input type.
    
    `email` and `tel` input types do have selection capabilities, so in
    that case, `hasSelectionCapabilities` should return `true`.
    spirosikmd committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    aa115f7 View commit details
    Browse the repository at this point in the history
Loading