Skip to content

Clearer ssr error message 11902 #11966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 4 commits into from
Feb 5, 2018
Merged

Clearer ssr error message 11902 #11966

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c68d1d
Match error message to one in `ReactFiber.js`
HeroProtagonist Feb 2, 2018
a398bc2
Add undefined/null guard and tests
HeroProtagonist Feb 3, 2018
6d69bdb
Update tests and element check
HeroProtagonist Feb 5, 2018
f1e2542
Remove beforeEach block
HeroProtagonist Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove beforeEach block
  • Loading branch information
@HeroProtagonist
HeroProtagonist committed Feb 5, 2018
commit f1e2542b0cd546bfc6d8de7de9fd6273d215ef7c
67 changes: 33 additions & 34 deletions packages/react-dom/src/__tests__/ReactDOMServerIntegrationElements-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,38 +873,20 @@ describe('ReactDOMServerIntegration', () => {
});

Copy link
Collaborator

@gaearon gaearon Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add another test case for undefined type.

describe('badly-typed elements', function() {
beforeEach(() => {
if (__DEV__) {
spyOnDev(console, 'error');
const originalCreateElement = React.createElement;
spyOnDev(React, 'createElement').and.callFake(el => {
const reactElement = originalCreateElement(el);

const isNull = el === null;
const receivedType = isNull ? 'null' : typeof el;

expect(console.error.calls.count()).toBe(1);
expect(console.error.calls.argsFor(0)[0]).toContain(
'Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a ' +
`class/function (for composite components) but got: ${
receivedType
}.` +
(!isNull
? " You likely forgot to export your component from the file it's defined in, " +
'or you might have mixed up default and named imports.'
: ''),
);

return reactElement;
});
}
});

itThrowsWhenRendering(
'object',
async render => {
const EmptyComponent = {};
await render(<EmptyComponent />);
let EmptyComponent = {};
expect(() => {
EmptyComponent = <EmptyComponent />;
}).toWarnDev(
'Warning: React.createElement: type is invalid -- expected a string ' +
'(for built-in components) or a class/function (for composite ' +
'components) but got: object. You likely forgot to export your ' +
"component from the file it's defined in, or you might have mixed up " +
'default and named imports.',
);
await render(EmptyComponent);
},
'Element type is invalid: expected a string (for built-in components) or a class/function ' +
'(for composite components) but got: object.' +
Expand All @@ -917,18 +899,35 @@ describe('ReactDOMServerIntegration', () => {
itThrowsWhenRendering(
'null',
async render => {
const NullComponent = null;
await render(<NullComponent />);
let NullComponent = null;
expect(() => {
NullComponent = <NullComponent />;
}).toWarnDev(
'Warning: React.createElement: type is invalid -- expected a string ' +
'(for built-in components) or a class/function (for composite ' +
'components) but got: null.',
);
await render(NullComponent);
},
'Element type is invalid: expected a string (for built-in components) or a class/function ' +
'(for composite components) but got: null.',
'(for composite components) but got: null',
);

itThrowsWhenRendering(
'undefined',
async render => {
const UndefinedComponent = undefined;
await render(<UndefinedComponent />);
let UndefinedComponent = undefined;
expect(() => {
UndefinedComponent = <UndefinedComponent />;
}).toWarnDev(
'Warning: React.createElement: type is invalid -- expected a string ' +
'(for built-in components) or a class/function (for composite ' +
'components) but got: undefined. You likely forgot to export your ' +
"component from the file it's defined in, or you might have mixed up " +
'default and named imports.',
);

await render(UndefinedComponent);
},
'Element type is invalid: expected a string (for built-in components) or a class/function ' +
'(for composite components) but got: undefined.' +
Expand Down