Skip to content

RFC 6: createReactClass updates #12036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 6 commits into from
Jan 19, 2018
Merged

RFC 6: createReactClass updates #12036

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
611b7fd
Added UNSAFE_ methods to create-class HAS_MANY list
bvaughn Jan 17, 2018
f0ac6ef
Added warning for UNSAFE_componentWillRecieveProps misspelling
bvaughn Jan 17, 2018
bfb17ca
Bumping create-react-class package version
bvaughn Jan 18, 2018
c47c083
Added support for static getDerivedStateFromProps mixins
bvaughn Jan 19, 2018
4644f99
Moved static gDSFP spec into separte spec config
bvaughn Jan 19, 2018
29cdc5a
Fixed UNSAFE_shouldComponentUpdate -> UNSAFE_componentWillUpdate
bvaughn Jan 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added UNSAFE_ methods to create-class HAS_MANY list
  • Loading branch information
@bvaughn
bvaughn committed Jan 17, 2018
commit 611b7fda8d38038e29febea65eac9f49cd6ea93a
21 changes: 21 additions & 0 deletions addons/create-react-class/factory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,20 @@ function factory(ReactComponent, isValidElement, ReactNoopUpdateQueue) {
*/
componentWillReceiveProps: 'DEFINE_MANY',

/**
* Replacement for (deprecated) `componentWillMount`.
*
* @optional
*/
UNSAFE_componentWillMount: 'DEFINE_MANY',

/**
* Replacement for (deprecated) `componentWillReceiveProps`.
*
* @optional
*/
UNSAFE_componentWillReceiveProps: 'DEFINE_MANY',

/**
* Invoked while deciding if the component should be updated as a result of
* receiving new props, state and/or context.
Expand Down Expand Up @@ -243,6 +257,13 @@ function factory(ReactComponent, isValidElement, ReactNoopUpdateQueue) {
*/
componentWillUpdate: 'DEFINE_MANY',

/**
* Replacement for (deprecated) `shouldComponentUpdate`.
*
* @optional
*/
UNSAFE_shouldComponentUpdate: 'DEFINE_MANY',
Copy link
Collaborator

@gaearon gaearon Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new to me. Why?

Copy link
Contributor Author

@bvaughn bvaughn Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Sorry! Looks like I fucked up there.

Copy link
Collaborator

@gaearon gaearon Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha no worries. Fresh eyes always help 👀


/**
* Invoked when the component's DOM representation has been updated.
*
Expand Down