Skip to content

Conversation

@joelbarbosa
Copy link

Fix: #12072

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@aweary
Copy link
Contributor

aweary commented Aug 17, 2018

Thanks for this @joelbarbosa! I made some minor changes to bring this up to date and then added a test.

@gaearon we should still do some browser testing, but on the surface this looks good to me.

@aweary aweary requested review from gaearon and nhunzaker August 17, 2018 22:14
@gaearon
Copy link
Collaborator

gaearon commented Aug 17, 2018

@aweary Do you want to take care of the testing?

@aweary
Copy link
Contributor

aweary commented Aug 17, 2018

@gaearon yes

Copy link
Contributor

@nhunzaker nhunzaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from testing, this looks good to me 👍

@nhunzaker
Copy link
Contributor

I'll update this with master and do some testing.

@nhunzaker
Copy link
Contributor

Well shoot, pushing to master is trickier than I thought. I've resubmitted this in #13643. I'll see it through.

@sizebot
Copy link

sizebot commented Sep 14, 2018

Details of bundled changes.

Comparing: b488a5d...b488a5d

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants