Skip to content

Resolve host configs at build time #12792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 15 commits into from
May 19, 2018
Merged

Resolve host configs at build time #12792

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a6ac452
Extract base Jest config
gaearon May 12, 2018
fe59043
Statically import the host config
gaearon May 12, 2018
cb2548e
Add scaffolding for importing an inlined renderer
gaearon May 12, 2018
f17323b
Fix the build
gaearon May 13, 2018
21a2916
ES exports for renderer methods
gaearon May 13, 2018
1ea7e4d
ES modules for host configs
gaearon May 13, 2018
d292923
Remove closures from the reconciler
gaearon May 13, 2018
265ba23
Check each renderer's config with Flow
gaearon May 16, 2018
6037625
Fix uncovered Flow issue
gaearon May 18, 2018
a501c8b
Prettier
gaearon May 18, 2018
a1b7241
Get rid of enable*Reconciler flags
gaearon May 18, 2018
7d7981f
Prettier again
gaearon May 18, 2018
e6410f9
Fix Flow config creation issue
gaearon May 18, 2018
bdcc773
Fix imprecise Flow typing
gaearon May 18, 2018
56ca671
Revert accidental changes
gaearon May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert accidental changes
  • Loading branch information
@gaearon
gaearon committed May 18, 2018
commit 56ca671d3cee4bd00e39b070b31e4bb665e1a3d9
1 change: 0 additions & 1 deletion packages/react-reconciler/src/ReactFiberReconciler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,4 +280,3 @@ export function injectIntoDevTools(devToolsConfig: DevToolsConfig): boolean {
},
});
}
// }
1 change: 1 addition & 0 deletions packages/react-reconciler/src/ReactFiberStack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export {
isEmpty,
pop,
push,
// DEV only:
checkThatStackIsEmpty,
resetStackAfterFatalErrorInDev,
};
Loading