Skip to content

Added production profiling bundle type #12886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 8 commits into from
Jun 11, 2018
Merged

Added production profiling bundle type #12886

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
36725a6
Added profiling bundle
May 22, 2018
e2bd865
Turned profiling on for React Fabric OSS profiling and dev bundles
May 22, 2018
dad05f5
Flow/Lint fix
May 22, 2018
03fede7
Revert "Flow/Lint fix"
Jun 10, 2018
6caf273
Added Flow declaration for __PROFILER__
Jun 10, 2018
29f09ac
__PROFILER__ -> __PROFILE__
Jun 10, 2018
82db19b
Profiler feature flags use single global var
Jun 10, 2018
cd39422
Set __PROFILE__ global for Jest tests
Jun 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Flow/Lint fix" 
This reverts commit 812beec.
  • Loading branch information
Brian Vaughn committed Jun 10, 2018
commit 03fede754c1f5087106c8ec414a17feeddf56e21
1 change: 1 addition & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,5 +81,6 @@ module.exports = {
spyOnDev: true,
spyOnDevAndProd: true,
spyOnProd: true,
__PROFILER__: true,
},
};
3 changes: 1 addition & 2 deletions packages/shared/ReactFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ export const warnAboutDeprecatedLifecycles = false;
export const warnAboutLegacyContextAPI = false;

// Gather advanced timing metrics for Profiler subtrees.
export const enableProfilerTimer =
__DEV__ || process.env.REACT_ENABLE_PROFILING === true;
export const enableProfilerTimer = __DEV__ || __PROFILER__;

// Fires getDerivedStateFromProps for state *or* props changes
export const fireGetDerivedStateFromPropsOnStateUpdates = true;
Expand Down
3 changes: 1 addition & 2 deletions packages/shared/forks/ReactFeatureFlags.native-fabric-oss.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ export const enableSuspense = false;
export const warnAboutDeprecatedLifecycles = false;
export const warnAboutLegacyContextAPI = false;
export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
export const enableProfilerTimer =
__DEV__ || process.env.REACT_ENABLE_PROFILING;
export const enableProfilerTimer = __DEV__ || __PROFILER__;
export const fireGetDerivedStateFromPropsOnStateUpdates = true;

// Only used in www builds.
Expand Down
3 changes: 1 addition & 2 deletions packages/shared/forks/ReactFeatureFlags.native-oss.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ export const enableUserTimingAPI = __DEV__;
export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
export const warnAboutDeprecatedLifecycles = false;
export const warnAboutLegacyContextAPI = false;
export const enableProfilerTimer =
__DEV__ || process.env.REACT_ENABLE_PROFILING;
export const enableProfilerTimer = __DEV__ || __PROFILER__;
export const fireGetDerivedStateFromPropsOnStateUpdates = true;

// Only used in www builds.
Expand Down
2 changes: 1 addition & 1 deletion scripts/rollup/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ function getPlugins(
// Turn __DEV__ and process.env checks into constants.
replace({
__DEV__: isProduction ? 'false' : 'true',
'process.env.REACT_ENABLE_PROFILING': isProfiling ? 'true' : 'false',
__PROFILER__: isProfiling ? 'true' : 'false',
'process.env.NODE_ENV': isProduction ? "'production'" : "'development'",
}),
// We still need CommonJS for external deps like object-assign.
Expand Down