Skip to content

Fix a crash when using dynamic children in <option> tag #13261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 10 commits into from
Aug 1, 2018
Merged

Fix a crash when using dynamic children in <option> tag #13261

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
388028e
Make option children a text content by default
Slowyn Jul 24, 2018
f829340
Apply requested changes
Slowyn Jul 26, 2018
73697ef
remove empty row
Slowyn Jul 26, 2018
65691b6
Update comment
Slowyn Jul 26, 2018
9ca2085
Add a simple unit-test
Slowyn Jul 26, 2018
931417b
[WIP: no flow] Pass through hostContext
Slowyn Jul 26, 2018
485d8db
[WIP: no flow] Give better description for test
Slowyn Aug 1, 2018
a6a8d1c
Fixes
gaearon Aug 1, 2018
7ccf3ce
Don't pass hostContext through
gaearon Aug 1, 2018
e614dbf
Also warn on hydration
gaearon Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a simple unit-test
  • Loading branch information
@Slowyn
Slowyn committed Jul 26, 2018
commit 9ca2085f98d7a3851cf461bf8ecabbdc5477702a
42 changes: 42 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOMSelect-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,48 @@ describe('ReactDOMSelect', () => {
expect(node.options[2].selected).toBe(false); // gorilla
});

it('should not fail', () => {
Copy link
Collaborator

@gaearon gaearon Jul 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very vague.

Copy link
Contributor Author

@Slowyn Slowyn Jul 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, It's some temporary "name" until we get a full working version.
Going to change it to some concrete form 😄

Have you taken a look on anccestorInfo in current case?

Copy link
Contributor Author

@Slowyn Slowyn Jul 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this description: "Options with stateful children; it should change its state properly and shouldn't fail"
What do you think?

const container = document.createElement('div');

let node;

function App({value}) {
return (
<select value={value} ref={n => (node = n)} onChange={noop}>
<option key="monkey" value="monkey">
A monkey {value === 'monkey' ? 'is chosen' : null}!
</option>
<option key="giraffe" value="giraffe">
A giraffe {value === 'giraffe' && 'is chosen'}!
</option>
<option key="gorilla" value="gorilla">
A gorilla {value === 'gorilla' && 'is chosen'}!
</option>
</select>
);
}

ReactDOM.render(
<App value={'monkey'} />,
container,
);

expect(node.options[0].selected).toBe(true); // monkey
expect(node.options[1].selected).toBe(false); // giraffe
expect(node.options[2].selected).toBe(false); // gorilla


ReactDOM.render(
<App value={'giraffe'} />,
container,
);

expect(node.options[0].selected).toBe(false); // monkey
expect(node.options[1].selected).toBe(true); // giraffe
expect(node.options[2].selected).toBe(false); // gorilla

});

it('should warn if value is null', () => {
expect(() =>
ReactTestUtils.renderIntoDocument(
Expand Down