Skip to content

Conversation

@nishp1
Copy link
Contributor

@nishp1 nishp1 commented Sep 7, 2018

Update README so it can be built successfully locally.

@pull-bot
Copy link

pull-bot commented Sep 7, 2018

Details of bundled changes.

Comparing: 7bcc077...e948c42

schedule

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
schedule.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
schedule.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

# 1: Build react from source
cd /path/to/react
yarn
yarn build dom,core,interaction,simple-cache-provider --type=NODE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same change could benefit the suspense demo readme too. And is there an interaction-package or was that an earlier name of schedule?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated suspense readme. Not 100% sure if interaction was renamed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interaction is now part of schedule

@gaearon gaearon merged commit c6dcf46 into facebook:master Sep 7, 2018
@gaearon
Copy link
Collaborator

gaearon commented Sep 7, 2018

Thanks

jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
* Build schedule which is required for time slicing demo

* Update suspense demo README too

* Update README.md

* Update README.md

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants