Skip to content

Ensure "addEventListener" exists on "window" for "scheduler" package #13731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trueadm merged 4 commits into from
Sep 26, 2018
Merged

Ensure "addEventListener" exists on "window" for "scheduler" package #13731

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6553e50
Ensure addEventListener exists on "window"
trueadm Sep 26, 2018
f968b84
Update conditional as per feedback
trueadm Sep 26, 2018
1e99062
fix typo
trueadm Sep 26, 2018
c35bf9f
run prettier
trueadm Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update conditional as per feedback
  • Loading branch information
@trueadm
trueadm committed Sep 26, 2018
commit f968b8418be7846cb43d71c008c992af5d8cd3d0
12 changes: 5 additions & 7 deletions packages/scheduler/src/Scheduler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,9 @@ var requestHostCallback;
var cancelHostCallback;
var getFrameDeadline;

if (typeof window === 'undefined') {
// "addEventListener" might not be available on the window object
// if this is a mocked "window" object. So we need to validate that too.
if (typeof window === 'undefined' || typeof window.addEventListener === 'function') {
// If this accidentally gets imported in a non-browser environment, fallback
// to a naive implementation.
var timeoutID = -1;
Expand Down Expand Up @@ -573,12 +575,8 @@ if (typeof window === 'undefined') {
}
};
// Assumes that we have addEventListener in this environment. Might need
// something better for old IE. Furthermore, "addEventListener" might not
// be available on the window object (if this is a RN mocked window),
// so we should check that it's a function before attaching the listener.
if (typeof window.addEventListener === 'function') {
window.addEventListener('message', idleTick, false);
}
// something better for old IE.
window.addEventListener('message', idleTick, false);

var animationTick = function(rafTime) {
isAnimationFrameScheduled = false;
Expand Down