Skip to content

Rename AsyncMode -> ConcurrentMode #13732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trueadm merged 6 commits into from
Sep 26, 2018
Merged

Rename AsyncMode -> ConcurrentMode #13732

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c6fa33
Rename AsyncMode -> ConcurrentMode
trueadm Sep 26, 2018
5d6d348
Run Prettier
trueadm Sep 26, 2018
87728c3
Add deprecation warning for ReactIs.isAsyncMode
trueadm Sep 26, 2018
b9a3729
Prettier
trueadm Sep 26, 2018
2782831
add boolean flag around deprecation warning
trueadm Sep 26, 2018
d02c8b8
add DEV check
trueadm Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run Prettier
  • Loading branch information
@trueadm
trueadm committed Sep 26, 2018
commit 5d6d348e0d286cbe460f104095e847df4860e4ca
6 changes: 5 additions & 1 deletion packages/react-dom/src/client/ReactDOM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,11 @@ ReactWork.prototype._onCommit = function(): void {
}
};

function ReactRoot(container: Container, isConcurrent: boolean, hydrate: boolean) {
function ReactRoot(
container: Container,
isConcurrent: boolean,
hydrate: boolean,
) {
const root = DOMRenderer.createContainer(container, isConcurrent, hydrate);
this._internalRoot = root;
}
Expand Down
10 changes: 8 additions & 2 deletions packages/react-noop-renderer/src/createReactNoop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,10 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
renderLegacySyncRoot(element: React$Element<any>, callback: ?Function) {
const rootID = DEFAULT_ROOT_ID;
const isConcurrent = false;
const container = ReactNoop.getOrCreateRootContainer(rootID, isConcurrent);
const container = ReactNoop.getOrCreateRootContainer(
rootID,
isConcurrent,
);
const root = roots.get(container.rootID);
NoopRenderer.updateContainer(element, root, null, callback);
},
Expand All @@ -490,7 +493,10 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
callback: ?Function,
) {
const isConcurrent = true;
const container = ReactNoop.getOrCreateRootContainer(rootID, isConcurrent);
const container = ReactNoop.getOrCreateRootContainer(
rootID,
isConcurrent,
);
const root = roots.get(container.rootID);
NoopRenderer.updateContainer(element, root, null, callback);
},
Expand Down