Skip to content

Add a checkbox to fixtures UI to choose React production build #13786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhunzaker merged 3 commits into from
Nov 14, 2018
Merged

Add a checkbox to fixtures UI to choose React production build #13786

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f72be8
Add a checkbox to fixtures UI to choose React production build
poeschko Sep 11, 2018
ccc5849
Assign header__label class name to label directly, instead of using a…
poeschko Nov 14, 2018
8d0db37
center the production checkbox vertically
poeschko Nov 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Assign header__label class name to label directly, instead of using a… 
… separate span
  • Loading branch information
@poeschko
poeschko committed Nov 14, 2018
commit ccc5849366e04a17d3ceb4db1c022026e73ff693
4 changes: 2 additions & 2 deletions fixtures/dom/src/components/Header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ class Header extends React.Component {
checked={this.state.production}
onChange={this.handleProductionChange}
/>
Copy link
Contributor

@nhunzaker nhunzaker Oct 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a style to center this vertically with the label? maybe:

.header__checkbox {
  vertical-align: middle;
}

Copy link
Contributor Author

@poeschko poeschko Nov 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, done.

<label htmlFor="react_production">
<span className="header__label">Production</span>
<label htmlFor="react_production" className="header__label">
Production
</label>
<label htmlFor="example">
<span className="sr-only">Select an example</span>
Expand Down