Skip to content

Add support for React.pure in ReactDOMServer #13855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebmarkbage merged 2 commits into from
Oct 20, 2018
Merged

Add support for React.pure in ReactDOMServer #13855

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c07089
Add support for React.pure in ReactDOMServer
alexmckenley Oct 15, 2018
28f5c3b
Unwrap pure wrappers by creating an additional element as a single child
sebmarkbage Oct 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Unwrap pure wrappers by creating an additional element as a single child 
This is very slow but meh. We're rewriting this whole thing anyway.
  • Loading branch information
@sebmarkbage
sebmarkbage committed Oct 20, 2018
commit 28f5c3bc8eb78192d3811f0c535b6a0200894b6d
18 changes: 6 additions & 12 deletions packages/react-dom/src/server/ReactPartialRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,18 +1004,12 @@ class ReactDOMServerRenderer {
}
case REACT_PURE_TYPE: {
const element: ReactElement = ((nextChild: any): ReactElement);
let nextChildren;
if (
typeof elementType.render === 'object' && elementType.render !== null && elementType.render.$$typeof === REACT_FORWARD_REF_TYPE
) {
nextChildren = toArray(
elementType.render.render(element.props, element.ref),
);
} else {
nextChildren = toArray(
elementType.render(element.props),
);
}
let nextChildren = [
React.createElement(
elementType.type,
Object.assign({ref: element.ref}, element.props),
),
];
const frame: Frame = {
type: null,
domNamespace: parentNamespace,
Expand Down