Skip to content

Avoid importing Scheduler directly #14757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acdlite merged 2 commits into from
Feb 5, 2019
Merged

Avoid importing Scheduler directly #14757

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ebe54e
Avoid importing Scheduler directly
acdlite Feb 5, 2019
e0ea64b
Make throwaway root id longer to appease Brian
acdlite Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make throwaway root id longer to appease Brian
  • Loading branch information
@acdlite
acdlite committed Feb 5, 2019
commit e0ea64bdf9e8113045b84842a1c860226dda6388
2 changes: 1 addition & 1 deletion packages/react-noop-renderer/src/createReactNoop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
flushPassiveEffects() {
// Trick to flush passive effects without exposing an internal API:
// Create a throwaway root and schedule a dummy update on it.
const rootID = 'bloop';
const rootID = 'bloopandthenmoreletterstoavoidaconflict';
const container = {rootID: rootID, children: []};
rootContainers.set(rootID, container);
const root = NoopRenderer.createContainer(container, true, false);
Expand Down