Skip to content

[React Native] measure calls will now call FabricUIManager #15324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 9, 2019
Merged

[React Native] measure calls will now call FabricUIManager #15324

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
85da8b7
[React Native] Add tests to paper renderer for measure, measureLayout
elicwhite Apr 4, 2019
eeb8d00
[React Native] measure calls will now call FabricUIManager
elicwhite Apr 4, 2019
6ac6555
Fixing Flow
elicwhite Apr 4, 2019
f7a6811
Merge remote-tracking branch 'upstream/master' into HEAD
elicwhite Apr 4, 2019
c6702f5
Add FabricUIManager to externals for paper renderer
elicwhite Apr 4, 2019
2175415
import * as FabricUIManager from 'FabricUIManager';
elicwhite Apr 9, 2019
8284dd9
Update tests
elicwhite Apr 9, 2019
c7ec6ab
Shouldn't have removed UIManager import
elicwhite Apr 9, 2019
298eea3
Merge branch 'fixed-measure-tests' into fabric-measure-calls
elicwhite Apr 9, 2019
cd087b0
Update with the new tests
elicwhite Apr 9, 2019
a012aa1
Merge branch 'master' into fabric-measure-calls
elicwhite Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
import * as FabricUIManager from 'FabricUIManager';
  • Loading branch information
@elicwhite
elicwhite committed Apr 9, 2019
commit 21754154c69e8447f9d76bb459e7745dd1d7d036
2 changes: 1 addition & 1 deletion packages/react-native-renderer/src/NativeMethodsMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import type {
import invariant from 'shared/invariant';
// Modules provided by RN:
import TextInputState from 'TextInputState';
import FabricUIManager from 'FabricUIManager';
import * as FabricUIManager from 'FabricUIManager';
import UIManager from 'UIManager';

import {create} from './ReactNativeAttributePayload';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-renderer/src/ReactNativeComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import type {
import React from 'react';
// Modules provided by RN:
import TextInputState from 'TextInputState';
import FabricUIManager from 'FabricUIManager';
import * as FabricUIManager from 'FabricUIManager';
import UIManager from 'UIManager';

import {create} from './ReactNativeAttributePayload';
Expand Down