Skip to content

Don't hyphenate custom CSS properties for ReactDOMServer #16167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 26, 2019
+22 −2
Merged

Don't hyphenate custom CSS properties for ReactDOMServer #16167

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9dd75f6
Do not hyphenate custom CSS property
bedakb Jul 19, 2019
bd046c9
Move check into the processStyleName fn
bedakb Jul 20, 2019
b08743b
Formatting
bedakb Jul 20, 2019
63c4e82
add test
bedakb Jul 20, 2019
f510cff
Put isCustomProperty check after conditional return
bedakb Jul 20, 2019
34c5fb0
add test to `ReactDOMServerIntegration` and supress warning
bedakb Jul 20, 2019
39e5c12
Don't indexOf twice
gaearon Jul 26, 2019
071824c
Simpler fix
gaearon Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test to ReactDOMServerIntegration and supress warning
  • Loading branch information
@bedakb
bedakb committed Jul 20, 2019
commit 34c5fb034c7a705a5ce19fbf3d263f0e943bf43d
5 changes: 5 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,11 @@ describe('ReactDOMServerIntegration', () => {
expect(e.style.Foo).toBe('5');
});

itRenders('camel cased custom properties', async render => {
const e = await render(<div style={{'--someColor': '#000000'}} />);
expect(e.style.SomeColor).toBe('#000000');
});

itRenders('no undefined styles', async render => {
const e = await render(
<div style={{color: undefined, width: '30px'}} />,
Expand Down
5 changes: 4 additions & 1 deletion packages/react-dom/src/shared/CSSPropertyOperations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ export function createDangerousStringForStyles(styles) {
const styleValue = styles[styleName];
if (styleValue != null) {
const isCustomProperty = styleName.indexOf('--') === 0;
serialized += delimiter + hyphenateStyleName(styleName) + ':';
serialized +=
delimiter +
(isCustomProperty ? styleName : hyphenateStyleName(styleName)) +
':';
serialized += dangerousStyleValue(
styleName,
styleValue,
Expand Down