Skip to content

[suspense][error handling] Inline renderRoot and fix error handling bug #16801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 23, 2019
Merged

[suspense][error handling] Inline renderRoot and fix error handling bug #16801

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
65edc8d
[scheduler][profiler] Start time of delayed tasks
acdlite Sep 17, 2019
6d5a2c2
[suspense][error handling] Add failing unit test
acdlite Sep 17, 2019
975636b
Outline push/pop logic in `renderRoot`
acdlite Sep 16, 2019
3017781
Extract `catch` block into helper function
acdlite Sep 16, 2019
0f64c2d
Fork `renderRoot` for sync and concurrent
acdlite Sep 16, 2019
acfb818
Extra "root completion" logic to separate function
acdlite Sep 16, 2019
35ab8c0
Inline `renderRoot`
acdlite Sep 16, 2019
17d59fc
Remove ad hoc `throw`
acdlite Sep 16, 2019
d69643c
Handle errors that occur on unwind
acdlite Sep 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[scheduler][profiler] Start time of delayed tasks 
Fixes a bug in the Scheduler profiler where the start time of a delayed
tasks is always 0.
  • Loading branch information
@acdlite
acdlite committed Sep 23, 2019
commit 65edc8d9835f378faba1c2cc6ca612d969fd1e1e

No changes to show.

This commit has no content.