Skip to content

Migrate useDeferredValue and useTransition #17058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 18, 2019
Merged

Migrate useDeferredValue and useTransition #17058

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9ea8084
test
lunaruan Oct 10, 2019
3b44db5
spacing
lunaruan Oct 10, 2019
10c30ee
spacing
lunaruan Oct 10, 2019
2dd8b35
Merge branch 'use_suspense_deferred_val' of https://github.com/lunaru…
lunaruan Oct 10, 2019
0067615
renamed to useTransition and useDeferredValue
lunaruan Oct 10, 2019
ab07c5a
use enableStableConcurrentModeAPIs and updated warning
lunaruan Oct 10, 2019
7b7db2d
added a busyDelayMs/busyMinDurationMs test
lunaruan Oct 11, 2019
24e4bfa
Merge branch 'master' of https://github.com/facebook/react into use_s…
lunaruan Oct 16, 2019
4fdb6e0
updated according to comments
lunaruan Oct 18, 2019
c0ddda1
fixed ReactHooks test
lunaruan Oct 18, 2019
666e922
removed warnings
lunaruan Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spacing
  • Loading branch information
@lunaruan
lunaruan committed Oct 10, 2019
commit 10c30ee3a95e7ec93e6d217d276097e348412713
5 changes: 3 additions & 2 deletions packages/react-reconciler/src/ReactFiberHooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ function mountSuspenseDeferredValue<T>(
mountEffect(
() => {
Scheduler.unstable_next(() => {
const previousConfig = requestCurrentSuspenseConfig();
const previousConfig = ReactCurrentBatchConfig.suspense;
ReactCurrentBatchConfig.suspense = config === undefined ? null : config;
try {
setValue(value);
Expand All @@ -1158,7 +1158,7 @@ function updateSuspenseDeferredValue<T>(
updateEffect(
() => {
Scheduler.unstable_next(() => {
const previousConfig = requestCurrentSuspenseConfig();
const previousConfig = ReactCurrentBatchConfig.suspense;
ReactCurrentBatchConfig.suspense = config === undefined ? null : config;
try {
setValue(value);
Expand Down Expand Up @@ -1237,6 +1237,7 @@ function dispatchAction<S, A>(
'rendering, declare it in the component body with useEffect().',
);
}

const alternate = fiber.alternate;
if (
fiber === currentlyRenderingFiber ||
Expand Down