Skip to content

Filter certain DOM attributes (e.g. src) if value is empty string #18513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2020
Merged

Filter certain DOM attributes (e.g. src) if value is empty string #18513

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8ac921
Filter certain DOM attributes (e.g. src, href) if their values are em…
Apr 7, 2020
07f02dc
Expanded warning recommendation
Apr 7, 2020
e0e2ab5
Improved error message
Apr 7, 2020
2399b82
Further refined error message
Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Expanded warning recommendation
  • Loading branch information
Brian Vaughn committed Apr 7, 2020
commit 07f02dc4d97d0024d120ce2b04ffacd497f6784b
3 changes: 2 additions & 1 deletion packages/react-dom/src/shared/DOMProperty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ export function shouldRemoveAttribute(
if (__DEV__) {
console.error(
'Invalid value "" (empty string) for attribute `%s`. ' +
'Use `null` instead to indicate an empty value.',
'This will be a no-op. Either do not render the element at all ' +
'or use `null` instead to indicate an empty value.',
name,
);
}
Expand Down