-
Notifications
You must be signed in to change notification settings - Fork 51k
Improved dev experience when DevTools hook is disabled #20208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
cbd376c
fb7136d
237286f
46b6692
9cdc308
1d833fa
6115e23
700ca1c
a581a3b
4937155
8527d9d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -470,7 +470,7 @@ export function injectIntoGlobalHook(globalObject: any): void { | |
| // of DevTools integration and associated warnings and logs. | ||
| // Using console['warn'] to evade Babel and ESLint | ||
| console['warn']( | ||
| 'Something has shimmed the React DevTools global hook (REACT_DEVTOOLS_GLOBAL_HOOK). ' + | ||
| 'Something has shimmed the React DevTools global hook (__REACT_DEVTOOLS_GLOBAL_HOOK__). ' + | ||
| 'Fast Refresh is not compatible with this shim and will be disabled.', | ||
| ); | ||
| return; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding the console warning wasn't actually disabling Fast Refresh. Needed to add
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @bvaughn thanks. Skipped my mind. |
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.