-
Notifications
You must be signed in to change notification settings - Fork 50k
Support named exports from client references #20312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
86cbf6c
Rename "name"->"filepath" field on Webpack module references
sebmarkbage aac1d3e
Switch back to transformSource instead of getSource
sebmarkbage ac4762d
Add acorn dependency
sebmarkbage cded3bb
Parse exported names of ESM modules
sebmarkbage 403501f
Handle imported names one level deep in CommonJS using a Proxy
sebmarkbage 0afb1b4
Add export name to module reference and Webpack map
sebmarkbage d4e4585
Special case plain CJS requires and conditional imports using __esModule
sebmarkbage a5f7228
Dedupe acorn-related deps
Andarist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Special case plain CJS requires and conditional imports using __esModule
This models if the server tries to import .default or a plain require. We should replicate the same thing on the client when we load that module reference.
- Loading branch information
commit d4e458555321fe1d6242c0c5042039c830d66b63
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually test CJS server paths by removing the
"type": "module"definition in package.json. In this case I need to use raw CJS (require(...)+module.exports) without using Babel/Webpack. Because otherwise we fall into the case below.I couldn't test the Webpack client paths for true CJS. I spent a few hours trying to figure out how to make the react-script config let me write raw CJS instead of transpiling from ESM and I couldn't because webpack kept treating them as ESM which means that assigning to module.exports causes and error.
I think this works though.