Skip to content

Flight: Support Webpack v5 #20524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Flight: Support Webpack v5 #20524

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c3f621d
Flight-webpack: Include ts\tsx\jsx modules as well
samcooke98 Dec 28, 2020
2a6c136
Add tests
samcooke98 Dec 28, 2020
71b978f
Extend the test to include named imports
samcooke98 Dec 28, 2020
dbe62f8
Add webpack v5 specific API's
samcooke98 Dec 28, 2020
3135386
Refactor to reduce code duplication
samcooke98 Dec 30, 2020
61d3dc8
Prettier & Linting
samcooke98 Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Flight-webpack: Include ts\tsx\jsx modules as well
  • Loading branch information
@samcooke98
samcooke98 committed Dec 28, 2020
commit c3f621dc646e6c21eec6231751f1ca3c0c8535c1
2 changes: 1 addition & 1 deletion packages/react-server-dom-webpack/src/ReactFlightWebpackPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export default class ReactFlightWebpackPlugin {
// TODO: Hook into deps instead of the target module.
// That way we know by the type of dep whether to include.
// It also resolves conflicts when the same module is in multiple chunks.
if (!/\.client\.js$/.test(mod.resource)) {
if (!/\.client\.(js|jsx|ts|tsx)$/.test(mod.resource)) {
return;
}
const moduleExports = {};
Expand Down