Skip to content

Don't warn about concurrently rendering contexts if we finished rendering #22797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 12, 2023
+68 −1
Merged

Don't warn about concurrently rendering contexts if we finished rendering #22797

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
67b5c96
Expected behavior
eps1lon Nov 20, 2021
bb33098
Don't warn about concurrent provider renders if we finished rendering
eps1lon Nov 20, 2021
91b9705
Only need to reset in DEV since we only set in DEV
eps1lon Nov 20, 2021
2ab9b80
Restore currentRenderN instead of resetting it
eps1lon Mar 5, 2022
4e9a32e
Update packages/react-reconciler/src/__tests__/ReactNewContext-test.js
eps1lon Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't warn about concurrent provider renders if we finished rendering
  • Loading branch information
@eps1lon
eps1lon authored and Sebastian Silbermann committed Jan 11, 2023
commit bb3309874eccc55dcc91ff843bd30742d90fec85
2 changes: 2 additions & 0 deletions packages/react-reconciler/src/ReactFiberNewContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ export function popProvider(
} else {
context._currentValue = currentValue;
}
context._currentRenderer = null;
} else {
if (
enableServerContext &&
Expand All @@ -150,6 +151,7 @@ export function popProvider(
} else {
context._currentValue2 = currentValue;
}
context._currentRenderer2 = null;
}
}

Expand Down